Re: [PATCH net-next 3/3] net: hns3: add support for link diagnosis info in debugfs

[huangguangbin (A)]

On 2021/6/25 3:25, Jakub Kicinski wrote:
> On Thu, 24 Jun 2021 22:36:45 +0800 Guangbin Huang wrote:
> > In order to know reason why link down, add a debugfs file
> > "link_diagnosis_info" to get link faults from firmware, and each bit
> > represents one kind of fault.
> >
> > usage example:
> > $ cat link_diagnosis_info
> > Reference clock lost
>
> Please use ethtool->get_link_ext_state instead.
> .
Hi Jakub, I have a question to consult you.
Some fault information in our patch are not existed in current ethtool extended
link states, for examples:
"Serdes reference clock lost"
"Serdes analog loss of signal"
"SFP tx is disabled"
"PHY power down"
"Remote fault"

Do you think these fault information can be added to ethtool extended link states?

Thanks,
Guangbin
.