Re: [PATCH] mm: cleancache: fix potential race in cleancache apis

From: Matthew Wilcox
Date: Thu Jul 01 2021 - 07:58:49 EST


On Thu, Jul 01, 2021 at 05:56:50PM +0900, 권오훈 wrote:
> On Thu, Jul 01, 2021 at 07:58:36AM +0200, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > On Thu, Jul 01, 2021 at 02:06:44PM +0900, 권오훈 wrote:
> > > We are using Cleancache APIs for our proprietary feature in Samsung.
> > > As Wilcox mentioned, however, there is no cleancache backend in current kernel
> > > mainline.
> > > So if the race patch shall be accepted, then it seems unnecessary to patch
> > > previous stable kernels.
> > >
> > > Meanwhile, I personally think cleancache API still has potential to be a good
> > > material when used with new arising technologies such as pmem or NVMe.
> > >
> > > So I suggest to postpone removing cleancache for a while.
> >
> > If there are no in-kernel users, it needs to be removed. If you rely on
> > this, wonderful, please submit your code as soon as possible.
> >
> > thanks,
> >
> > greg k-h
> >
> We will discuss internally and see if we can submit our feature.

You have two months. I'll submit the removal then if no new backend has
shown up.