Re: [PATCH v5 5/5] perf arm-spe: Don't wait for PERF_RECORD_EXIT event
From: Arnaldo Carvalho de Melo
Date: Thu Jul 01 2021 - 13:03:24 EST
Em Mon, Jun 28, 2021 at 08:12:17PM +0800, Leo Yan escreveu:
> On Fri, Jun 25, 2021 at 02:25:15PM +0100, James Clark wrote:
> > For the whole set:
> > Reviewed-by: James Clark <james.clark@xxxxxxx>
> > Tested-by: James Clark <james.clark@xxxxxxx>
> > I see a big improvement in decoding involving multiple processes because the timestamps are now
> >
> > For example perf-exec samples are visible right before the exec is done, and on an
> > application that forks, samples are visible from all processes. For example:
> > perf record -e arm_spe// -- bash -c "stress -c 1"
> > perf script
> > perf-exec 4502 [003] 259755.050409: 1 l1d-access: ffff80001014b840 sched_clock+0x40 ([kernel.kallsyms])
> > perf-exec 4502 [003] 259755.050409: 1 tlb-access: ffff80001014b840 sched_clock+0x40 ([kernel.kallsyms])
> > perf-exec 4502 [003] 259755.050409: 1 memory: ffff80001014b840 sched_clock+0x40 ([kernel.kallsyms])
> > perf-exec 4502 [003] 259755.050411: 1 tlb-access: ffff800010120fb8 __rcu_read_lock+0x0 ([kernel.kallsyms])
> > bash 4502 [003] 259755.050411: 1 branch-miss: ffff8000105b2a40 memcpy+0x80 ([kernel.kallsyms])
> > bash 4502 [003] 259755.050411: 1 tlb-access: 0 [unknown] ([unknown])
> > ...
> > stress 4502 [003] 259755.051468: 1 l1d-access: ffff800010259a24 __vma_adjust+0x1f4 ([kernel.kallsyms])
> > stress 4502 [003] 259755.051468: 1 tlb-access: ffff800010259a24 __vma_adjust+0x1f4 ([kernel.kallsyms])
> > stress 4502 [003] 259755.051468: 1 memory: ffff800010259a24 __vma_adjust+0x1f4 ([kernel.kallsyms])
> > Previously samples were only attributed to 'stress', which was obviously wrong.
>
> Thanks a lot for the review and testing, James!
>
> Hi Arnaldo, I confirmed this patch set can be cleanly applied on
> the latest acme/perf/core branch, so could you pick up this patch
> set?
Applied, thanks, please let me know if there is still something
outstanding,
- Arnaldo