Re: [PATCH 1/3] dt-bindings: soc: qcom: aoss: Add SC8180X compatible

[Bjorn Andersson]

On Thu 01 Jul 14:03 CDT 2021, Rob Herring wrote:

> On Fri, Jun 25, 2021 at 04:40:16PM -0700, Bjorn Andersson wrote:
> > Add compatible for the Qualcomm SC8180x platform to the AOSS QMP
> > binding.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > index 783dc81b0f26..3747032311a4 100644
> > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> > @@ -18,10 +18,13 @@ power-domains.
> >  	Definition: must be one of:
> >  		    "qcom,sc7180-aoss-qmp"
> >  		    "qcom,sc7280-aoss-qmp"
> > +		    "qcom,sc8180x-aoss-qmp"
> >  		    "qcom,sdm845-aoss-qmp"
> >  		    "qcom,sm8150-aoss-qmp"
> >  		    "qcom,sm8250-aoss-qmp"
> >  		    "qcom,sm8350-aoss-qmp"
> > +		    and:
> > +		    "qcom,aoss-qmp"
> 
> This was missing from all the existing ones or is an addition?
> 

We've only had platform-specific compatibles for this binding (and
implementation) so far, this patch adds sc8180x and a common compatible.

So the commit message should have been rewritten to cover this as I
extended my original patch. Sorry for missing that.

Regards,
Bjorn

> >  
> >  - reg:
> >  	Usage: required
> > @@ -70,7 +73,7 @@ The following example represents the AOSS side-channel message RAM and the
> >  mechanism exposing the power-domains, as found in SDM845.
> >  
> >    aoss_qmp: qmp@c300000 {
> > -	  compatible = "qcom,sdm845-aoss-qmp";
> > +	  compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp";
> >  	  reg = <0x0c300000 0x100000>;
> >  	  interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
> >  	  mboxes = <&apss_shared 0>;
> > -- 
> > 2.29.2
> > 
> >