Re: [PATCH] perf: tests: fix some mmemory leak issues

[Arnaldo Carvalho de Melo]

Em Thu, Jul 01, 2021 at 09:09:55PM -0700, gushengxian escreveu:
> From: gushengxian <gushengxian@xxxxxxxxxx>
> 
> Some memory leak issues should be fixed by free().
> Reported by cppcheck.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: gushengxian <gushengxian@xxxxxxxxxx>
> ---
>  tools/perf/arch/arm/tests/dwarf-unwind.c     | 1 +
>  tools/perf/arch/arm64/tests/dwarf-unwind.c   | 1 +
>  tools/perf/arch/powerpc/tests/dwarf-unwind.c | 1 +
>  tools/perf/arch/x86/tests/dwarf-unwind.c     | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/tools/perf/arch/arm/tests/dwarf-unwind.c b/tools/perf/arch/arm/tests/dwarf-unwind.c
> index ccfa87055c4a..f2541d1dbb02 100644
> --- a/tools/perf/arch/arm/tests/dwarf-unwind.c
> +++ b/tools/perf/arch/arm/tests/dwarf-unwind.c
> @@ -39,6 +39,7 @@ static int sample_ustack(struct perf_sample *sample,
>  	memcpy(buf, (void *) sp, stack_size);
>  	stack->data = (char *) buf;
>  	stack->size = stack_size;
> +	free(buf);
>  	return 0;
>  }
>  
> diff --git a/tools/perf/arch/arm64/tests/dwarf-unwind.c b/tools/perf/arch/arm64/tests/dwarf-unwind.c
> index 46147a483049..ecd25c77a71f 100644
> --- a/tools/perf/arch/arm64/tests/dwarf-unwind.c
> +++ b/tools/perf/arch/arm64/tests/dwarf-unwind.c
> @@ -39,6 +39,7 @@ static int sample_ustack(struct perf_sample *sample,
>  	memcpy(buf, (void *) sp, stack_size);
>  	stack->data = (char *) buf;
>  	stack->size = stack_size;
> +	free(buf);
>  	return 0;
>  }
>  
> diff --git a/tools/perf/arch/powerpc/tests/dwarf-unwind.c b/tools/perf/arch/powerpc/tests/dwarf-unwind.c
> index 8efd9ed9e9db..e57a8ca52ce7 100644
> --- a/tools/perf/arch/powerpc/tests/dwarf-unwind.c
> +++ b/tools/perf/arch/powerpc/tests/dwarf-unwind.c
> @@ -40,6 +40,7 @@ static int sample_ustack(struct perf_sample *sample,
>  	memcpy(buf, (void *) sp, stack_size);
>  	stack->data = (char *) buf;
>  	stack->size = stack_size;
> +	free(buf);
>  	return 0;
>  }
>  
> diff --git a/tools/perf/arch/x86/tests/dwarf-unwind.c b/tools/perf/arch/x86/tests/dwarf-unwind.c
> index 478078fb0f22..da90b33a1e28 100644
> --- a/tools/perf/arch/x86/tests/dwarf-unwind.c
> +++ b/tools/perf/arch/x86/tests/dwarf-unwind.c
> @@ -47,6 +47,7 @@ static int sample_ustack(struct perf_sample *sample,
>  #endif
>  	stack->data = (char *) buf;
>  	stack->size = stack_size;
> +	free(buf);
>  	return 0;
>  }
>  
> -- 
> 2.25.1
> 

-- 

- Arnaldo