Re: [PATCH v1] Print a log when the sched clock is marked unstable

[Ani Sinha]

ping ...

On Sun, Jun 27, 2021 at 12:19 PM Ani Sinha <ani@xxxxxxxxxxx> wrote:
>
> In other parts of the kernel when the sched clock transitions from
> stable to unstable and vice versa, a kernel info log is printed.
> When the sched clock is marked explicitly as unstable, we should
> print an information log as well. This patch addresses this. It is
> useful in cases where for example, we want to understand why a
> certain feature like NOHZ, which depends on a stable sched clock, is
> not available.
>
> Signed-off-by: Ani Sinha <ani@xxxxxxxxxxx>
> ---
>  kernel/sched/clock.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> See also thread
> https://lkml.org/lkml/2021/6/20/32
>
> diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c
> index c2b2859ddd82..5a403b2c9b3f 100644
> --- a/kernel/sched/clock.c
> +++ b/kernel/sched/clock.c
> @@ -192,8 +192,10 @@ void clear_sched_clock_stable(void)
>
>         smp_mb(); /* matches sched_clock_init_late() */
>
> -       if (static_key_count(&sched_clock_running.key) == 2)
> +       if (static_key_count(&sched_clock_running.key) == 2) {
> +               pr_info("sched_clock: Marking unstable.\n");
>                 __clear_sched_clock_stable();
> +       }
>  }
>
>  static void __sched_clock_gtod_offset(void)
> --
> 2.25.1