Re: [GIT PULL] thermal for v5.14-rc1

From: Linus Torvalds
Date: Sat Jul 03 2021 - 15:37:23 EST


On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
>
> ssh://git@xxxxxxxxxxxxxxxxxxx/pub/scm/linux/kernel/git/thermal/linux.git
> tags/thermal-v5.14-rc1

This does not build for me. And I suspect it never built in linux-next either.

I get

ERROR: modpost: "tegra_fuse_readl"
[drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
ERROR: modpost: "tegra_fuse_readl"
[drivers/thermal/tegra/tegra-soctherm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
make[1]: *** Deleting file 'modules-only.symvers'
make: *** [Makefile:1762: modules] Error 2

and I think it's due to that commit 1f9c5936b10c
("thermal/drivers/tegra: Correct compile-testing of drivers") which
quite sensibly tries to extend build coverage for the tegra thermal
drivers, but that build coverage doesn't actually *work* outside the
tegra world.

That commit says "All Tegra thermal drivers support compile-testing",
but clearly they stumble at the last hurdle.

I made the decision to just unpull this, not because I couldn't fix
it, but because if it was this untested, I don't want to worry about
all the *other* code in there too.

Linus