Re: [PATCH v4] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized

From: David Miller
Date: Sat Jul 03 2021 - 18:04:37 EST


From: Nguyen Dinh Phi <phind.uet@xxxxxxxxx>
Date: Sat, 3 Jul 2021 17:34:17 +0800

> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index 7d5e59f688de..855ada2be25e 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -5922,7 +5922,6 @@ void tcp_init_transfer(struct sock *sk, int bpf_op, struct sk_buff *skb)
> tp->snd_cwnd = tcp_init_cwnd(tp, __sk_dst_get(sk));
> tp->snd_cwnd_stamp = tcp_jiffies32;
>
> - icsk->icsk_ca_initialized = 0;
> bpf_skops_established(sk, bpf_op, skb);
> if (!icsk->icsk_ca_initialized)
> tcp_init_congestion_control(sk);

Don't you have to make the tcp_init_congestion_control() call unconditional now?