Re: [PATCH v5 05/14] media: mtk-vcodec: venc: support START and STOP commands

From: Alexandre Courbot
Date: Mon Jul 05 2021 - 01:04:59 EST


On Fri, May 28, 2021 at 4:44 PM Dafna Hirschfeld
<dafna.hirschfeld@xxxxxxxxxxxxx> wrote:
> >> +static int vidioc_encoder_cmd(struct file *file, void *priv,
> >> + struct v4l2_encoder_cmd *cmd)
> >> +{
> >> + struct mtk_vcodec_ctx *ctx = fh_to_ctx(priv);
> >> + struct vb2_queue *src_vq, *dst_vq;
> >> + int ret;
>
> I see that the driver return -EIO on the ioctls when in state MTK_STATE_ABORT
> so you should probably test the state here as well.

Done, thanks for catching this!