Re: [PATCH v12] i2c: virtio: add a virtio i2c frontend driver

[Jie Deng]

On 2021/7/5 14:30, Viresh Kumar wrote:

> > This is still not enough to convince me.  So I won't change them for now
> > until I see it
> >
> > is the consensus of the majority.
> Do you see reqs[i] to ever be NULL here ? If not, then if (req) is like if
> (true).
>
> Why would you want to have something like that ?

No. Currently, virtio_i2c_complete_reqs is only called by 
virtio_i2c_xfer, thus we don't

have reqs[i] to be NULL. But I think "virtio_i2c_complete_reqs" as an 
independent function

should consider this from a callee perspective.

Anyway, if you really think it should be changed, it can be fixed 
incrementally as Wolfram said.