Re: [syzbot] general protection fault in blk_mq_run_hw_queues

From: Christoph Hellwig
Date: Mon Jul 05 2021 - 06:25:00 EST


On Mon, Jul 05, 2021 at 02:00:17PM +0800, Guoqing Jiang wrote:
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index 614d82e7fae4..d2548d36bf21 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -222,8 +222,8 @@ static void nbd_dev_remove(struct nbd_device *nbd)
>
>         if (disk) {
>                 del_gendisk(disk);
> -               blk_mq_free_tag_set(&nbd->tag_set);
>                 blk_cleanup_disk(disk);
> +               blk_mq_free_tag_set(&nbd->tag_set);
>         }
>
> Also paride/pd.c needs the same change, is my understanding correct?
> Christoph.

Yes. Do you have a patch or should I send one?