[linux-arm:cex7 52/52] drivers/bus/fsl-mc/fsl-mc-bus.c:166:42: error: 'struct iommu_fwspec' has no member named 'iommu_fwnode'

From: kernel test robot
Date: Mon Jul 05 2021 - 16:05:02 EST


tree: git://git.armlinux.org.uk/~rmk/linux-arm cex7
head: 3b4ad5b46d631c04726e3b7533b2360fa4a8b24f
commit: 3b4ad5b46d631c04726e3b7533b2360fa4a8b24f [52/52] bus: fsl-mc: add custom .dma_configure implementation
config: i386-randconfig-a003-20210705 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add linux-arm git://git.armlinux.org.uk/~rmk/linux-arm
git fetch --no-tags linux-arm cex7
git checkout 3b4ad5b46d631c04726e3b7533b2360fa4a8b24f
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/bus/fsl-mc/fsl-mc-bus.c: In function 'fsl_mc_dma_configure':
>> drivers/bus/fsl-mc/fsl-mc-bus.c:166:42: error: 'struct iommu_fwspec' has no member named 'iommu_fwnode'
166 | iommu_ops = iommu_ops_from_fwnode(fwspec->iommu_fwnode);
| ^~
drivers/bus/fsl-mc/fsl-mc-bus.c:170:37: error: 'struct iommu_fwspec' has no member named 'iommu_fwnode'
170 | ret = iommu_fwspec_init(dev, fwspec->iommu_fwnode, iommu_ops);
| ^~
>> drivers/bus/fsl-mc/fsl-mc-bus.c:181:9: error: implicit declaration of function 'iommu_probe_device'; did you mean 'iommu_detach_device'? [-Werror=implicit-function-declaration]
181 | ret = iommu_probe_device(dev);
| ^~~~~~~~~~~~~~~~~~
| iommu_detach_device
cc1: some warnings being treated as errors


vim +166 drivers/bus/fsl-mc/fsl-mc-bus.c

136
137 static int fsl_mc_dma_configure(struct device *dev)
138 {
139 struct device *dma_dev = dev;
140 struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
141 u32 input_id = mc_dev->icid;
142 struct iommu_fwspec *fwspec;
143 const struct iommu_ops *iommu_ops;
144 int ret;
145
146 /* Skip DMA setup for devices that are not DMA masters */
147 if (dev->type == &fsl_mc_bus_dpmcp_type ||
148 dev->type == &fsl_mc_bus_dpbp_type ||
149 dev->type == &fsl_mc_bus_dpcon_type ||
150 dev->type == &fsl_mc_bus_dpio_type)
151 return 0;
152
153 while (dev_is_fsl_mc(dma_dev))
154 dma_dev = dma_dev->parent;
155
156
157 #if 0
158 if (dev_of_node(dma_dev))
159 return of_dma_configure_id(dev, dma_dev->of_node, 0, &input_id);
160
161 return acpi_dma_configure_id(dev, DEV_DMA_COHERENT, &input_id);
162 #else
163 fwspec = dev_iommu_fwspec_get(dma_dev);
164 if (!fwspec)
165 return -ENODEV;
> 166 iommu_ops = iommu_ops_from_fwnode(fwspec->iommu_fwnode);
167 if (!iommu_ops)
168 return -ENODEV;
169
170 ret = iommu_fwspec_init(dev, fwspec->iommu_fwnode, iommu_ops);
171 if (ret)
172 return ret;
173
174 ret = iommu_fwspec_add_ids(dev, &input_id, 1);
175 if (ret) {
176 iommu_fwspec_free(dev);
177 return ret;
178 }
179
180 if (!device_iommu_mapped(dev)) {
> 181 ret = iommu_probe_device(dev);
182 if (ret) {
183 iommu_fwspec_free(dev);
184 return ret;
185 }
186 }
187
188 arch_setup_dma_ops(dev, 0, *dma_dev->dma_mask + 1, iommu_ops, true);
189
190 return 0;
191 #endif
192 }
193

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip