Re: [PATCH 5/9] irqchip/loongson-htvec: Add ACPI init support

[Marc Zyngier]

On Tue, 06 Jul 2021 04:09:00 +0100,
Huacai Chen <chenhuacai@xxxxxxxxxxx> wrote:
> 
> We are preparing to add new Loongson (based on LoongArch, not MIPS)
> support. LoongArch use ACPI other than DT as its boot protocol, so
> add ACPI init support.
> 
> Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> ---
>  drivers/irqchip/irq-loongson-htvec.c | 102 ++++++++++++++++++++++++++-
>  1 file changed, 101 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-loongson-htvec.c b/drivers/irqchip/irq-loongson-htvec.c
> index 60a335d7e64e..69452d4a33c0 100644
> --- a/drivers/irqchip/irq-loongson-htvec.c
> +++ b/drivers/irqchip/irq-loongson-htvec.c
> @@ -1,6 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
>   *  Copyright (C) 2020, Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> + *			Jianmin Lv <lvjianmin@xxxxxxxxxxx>
> + *			Huacai Chen <chenhuacai@xxxxxxxxxxx>

Drop this, move the suspend/resume code to its own patch, de-duplicate
the probing code.

Do I sound like a stuck record?

	M.

-- 
Without deviation from the norm, progress is not possible.