Re: [PATCH] bus: Make remove callback return void

From: Alexander Shishkin
Date: Tue Jul 06 2021 - 11:12:48 EST


Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> writes:

> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

FWIW, the intel_th bit is

Acked-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>