Re: [PATCH v12 00/17] Introduce the Counter character device interface

[William Breathitt Gray]

On Tue, Jul 06, 2021 at 02:40:01PM +0300, Jarkko Nikula wrote:
> Hi
> 
> On 7/5/21 11:18 AM, William Breathitt Gray wrote:
> > To summarize the main points of this patchset: there are no changes to
> > the existing Counter sysfs userspace interface; a Counter character
> > device interface is introduced that allows Counter events and associated
> > data to be read() by userspace; the events_configure() and
> > watch_validate() driver callbacks are introduced to support Counter
> > events; and IRQ support is added to the 104-QUAD-8 driver, serving as an
> > example of how to support the new Counter events functionality.
> > 
> I quickly tested this set on top of linux-next next-20210706 and didn't 
> see any issue with intel-qep.c. However I noticed two mutex issues in 
> patch 15/17. Perhaps visible due the CONFIG_DEBUG_MUTEXES=y etc. I have on.
> 
> I'll be out of office next few weeks so cannot test if you have a new 
> version meanwhile but wanted to share no show stopper from intel-qep.c 
> and those two mutex warnings.
> 
> Jarkko

Thanks, these seem pretty straightforward to fix so I'll wait a week or
so to see if any other issues pop up before making a v13 submission.

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature