Re: [PATCH AUTOSEL 5.10 113/137] wireless: wext-spy: Fix out-of-bounds warning

[Sasha Levin]

On Tue, Jul 06, 2021 at 04:08:09PM +0200, Johannes Berg wrote:
> On Tue, 2021-07-06 at 07:21 -0400, Sasha Levin wrote:
> > From: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
> >
> > [ Upstream commit e93bdd78406da9ed01554c51e38b2a02c8ef8025 ]
> >
> > Fix the following out-of-bounds warning:
> >
> > net/wireless/wext-spy.c:178:2: warning: 'memcpy' offset [25, 28] from the object at 'threshold' is out of the bounds of referenced subobject 'low' with type 'struct iw_quality' at offset 20 [-Warray-bounds]
>
> For the record: while this clearly isn't harmful, there's almost
> basically no chance that the stable kernel will ever compile warning-
> free with -Warray-bounds, so there's not much point in backporting this
> patch.

While the warning is a non-issue, it wasn't clear if it fixes a real bug
or just silences the warning which is why I took it in.

--
Thanks,
Sasha