Re: [PATCH v2] tracing: Add linear buckets to histogram logic

From: Tom Zanussi
Date: Wed Jul 07 2021 - 11:19:00 EST


On Wed, 2021-07-07 at 11:11 -0400, Steven Rostedt wrote:
> On Wed, 7 Jul 2021 07:00:32 -0700
> Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> > > I feel is farther from log2 than my version. Stating that "~"
> > > means
> > > approximation, what does "0 ~ 99" really mean?
> >
> > To me, it means "range". The original intention was to
> > express [FROM, TO) and I thought we can omit the FROM
> > since it's same as TO of the previous line. But we can use
> > inclusive ranges with FROM and TO for clarity.
> >
> > But it's up to you. I don't object to your change.
>
> Thanks, I'd like to keep it as is. Unless Tom has any issues with it.
>
> Tom?

Yeah, I prefer the explicit ranges too - it leaves nothing open to
interpretation.

Tom

>
> -- Steve