Re: [PATCH V7 0/4] Signaling api support in glink/rpmsg clients

[Bjorn Andersson]

On Tue 06 Jul 10:27 CDT 2021, Lee Jones wrote:

> On Wed, 2 Sept 2020 at 17:25, Deepak Kumar Singh <deesin@xxxxxxxxxxxxxx>
> wrote:
> 
> > Change from version 6
> > In last series(v6) i had put wrong version(v5) for cover note.
> > Which led to confusion for patch set series.
> >
> > In this series i have updated the label for cover letter(v7).
> > There is no change in patches. Only cover note label is updated.
> >
> > Change from version 5
> > [V6,4/4] rpmsg: char: Add signal callback and POLLPRI support
> > Updated for sparse warning. Replaced POLLPRI => EPOLLPRI to fix
> > warning.
> >
> > Change from version 4
> > I am taking over these patches from aneela@xxxxxxxxxxxxxx
> > Fixed all the trivial review comments.
> >
> > Signal conversion to and from native signal as done in patch V4,2/4
> > is intentional.
> >
> > Arun Kumar Neelakantam (3):
> >   rpmsg: glink: Add support to handle signals command
> >   rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
> >   rpmsg: char: Add signal callback and POLLPRI support
> >
> > Deepak Kumar Singh (1):
> >   rpmsg: core: Add signal API support
> >
> >  drivers/rpmsg/qcom_glink_native.c | 125
> > ++++++++++++++++++++++++++++++++++++++
> >  drivers/rpmsg/rpmsg_char.c        |  76 ++++++++++++++++++++++-
> >  drivers/rpmsg/rpmsg_core.c        |  40 ++++++++++++
> >  drivers/rpmsg/rpmsg_internal.h    |   5 ++
> >  include/linux/rpmsg.h             |  27 ++++++++
> >  5 files changed, 270 insertions(+), 3 deletions(-)
> >
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
> >
> Any idea why this died at v7?
> 

I had some concerns about the actual users of this and wanted the API to
be more generic. Deepak brought this up again recently and I think we
have a common understanding of how v8 should look like.

Regards,
Bjorn