Re: [PATCH] scripts/spdxcheck.py: Lets strictly read license files in utf-8

From: Jonathan Corbet
Date: Wed Jul 07 2021 - 12:53:15 EST


Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:

> Nishanth,
> On Fri, Jul 02 2021 at 20:21, Nishanth Menon wrote:
>> Commit bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")
>> unfortunately introduced LICENSES/dual/CC-BY-4.0 in UTF-8 Unicode text
>
> Sigh. Why are people adding such things w/o running this script in the
> first place.

I have a guess on that front ... there is nothing in our documentation
that says anybody should run it, and the script itself gives no
indication of what it does, when it should be run, or how to run it.
That might just reduce uptake a little bit...:)

I increasingly believe that anything we add to scripts/ should start
with a "usage" header describing why it exists and how to make it do its
thing. That would be a welcome addition to spdxcheck.py. Adding
something to Documentation/process/license-rules.html would be a nice
bonus.

Thanks,

jon