Re: [PATCH 3/7] libperf: Move leader to perf_evsel::leader

From: Jiri Olsa
Date: Wed Jul 07 2021 - 14:14:20 EST


On Wed, Jul 07, 2021 at 11:53:27AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 06, 2021 at 05:17:00PM +0200, Jiri Olsa escreveu:
> > Moving evsel::leader to perf_evsel::leader, so we can move
> > the group interface to libperf.
>
> I also had to apply this, because you didn't build with
> BUILD_BPF_SKEL=1, right?

ah right.. I also plan to build in arm/s390/ppc,
so I'll take what you have in tmp.perf/core

thanks,
jirka

>
> diff --git a/tools/perf/util/bpf_counter.c b/tools/perf/util/bpf_counter.c
> index 1d0b9742f7271966..8150e03367bbafad 100644
> --- a/tools/perf/util/bpf_counter.c
> +++ b/tools/perf/util/bpf_counter.c
> @@ -353,7 +353,7 @@ static int bperf_check_target(struct evsel *evsel,
> enum bperf_filter_type *filter_type,
> __u32 *filter_entry_cnt)
> {
> - if (evsel->leader->core.nr_members > 1) {
> + if (evsel->core.leader->nr_members > 1) {
> pr_err("bpf managed perf events do not yet support groups.\n");
> return -1;
> }
>