Re: [PATCH v2] ASoC: atmel: ATMEL drivers depend on HAS_DMA

[Alexandre Belloni]

On 07/07/2021 16:40:34+0000, Codrin.Ciubotariu@xxxxxxxxxxxxx wrote:
> On 29.06.2021 00:11, Randy Dunlap wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On a config (such as arch/sh/) which does not set HAS_DMA when MMU
> > is not set, several ATMEL ASoC drivers select symbols that cause
> > kconfig warnings. There is one "depends on HAS_DMA" here but several
> > more are needed to prevent kconfig warnings since 'select' does not
> > recognize any dependencies.
> > 
> > Fix the following kconfig warnings:
> > 
> > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
> >    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n]
> >    Selected by [m]:
> >    - SND_ATMEL_SOC_SSC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m]
> >    - SND_ATMEL_SOC_SSC_PDC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m]
> > 
> > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_PDC
> >    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n]
> >    Selected by [m]:
> >    - SND_AT91_SOC_SAM9G20_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m]
> > 
> > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC
> >    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n]
> >    Selected by [m]:
> >    - SND_ATMEL_SOC_SSC_DMA [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m]
> > 
> > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_DMA
> >    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n]
> >    Selected by [m]:
> >    - SND_ATMEL_SOC_WM8904 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && I2C [=m]
> >    - SND_AT91_SOC_SAM9X5_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m]
> 
> Hi Randy,
> 
> Sorry about my delayed response. I think it would be better to just 
> remove HAS_DMA from SND_ATMEL_SOC_PDC, since it seems to compile fine 
> without it. This should fix all the problems...
> 

I bet this is correct since m32r is gone.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com