Re: [PATCH] drivers: Follow the indentation coding standard on printks

From: Andrew Lunn
Date: Thu Jul 08 2021 - 10:54:05 EST


> --- a/drivers/atm/suni.c
> +++ b/drivers/atm/suni.c
> @@ -328,8 +328,8 @@ static int suni_start(struct atm_dev *dev)
> timer_setup(&poll_timer, suni_hz, 0);
> poll_timer.expires = jiffies+HZ;
> #if 0
> -printk(KERN_DEBUG "[u] p=0x%lx,n=0x%lx\n",(unsigned long) poll_timer.list.prev,
> - (unsigned long) poll_timer.list.next);
> + printk(KERN_DEBUG "[u] p=0x%lx,n=0x%lx\n",(unsigned long) poll_timer.list.prev,
> + (unsigned long) poll_timer.list.next);

Why not use DPRINTK(), defined at the start of suni.c?

Andrew