Re: linux-next: Fixes tag needs some work in the net tree
From: Florian Fainelli
Date: Thu Jul 08 2021 - 17:45:58 EST
On 7/8/21 2:44 PM, Eric Dumazet wrote:
>
>
> On 7/8/21 11:38 PM, Florian Fainelli wrote:
>> On 7/8/21 2:31 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>> 9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")
>>>
>>> Fixes tag
>>>
>>> Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
>>>
>>> has these problem(s):
>>>
>>> - No SHA1 recognised
>>>
>>> Not worth rebasing for, just more care next time.
>>
>> It is there though:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984
>>
>> and has the proper format AFAICT, what am I missing?
>>
>
> This commit was the first commit, adding the bug.
>
> Your commit changelog had :
>
> Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Reviewed-by: Roi Dayan <roid@xxxxxxxxxx>
> Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
>
> See the extra Fixes: word ?
Doh! yes, sorry about that.
--
Florian