Re: [PATCH] drivers: Follow the indentation coding standard on printks

[Helge Deller]

On 7/8/21 11:25 PM, Rolf Eike Beer wrote:
> Am Donnerstag, 8. Juli 2021, 15:10:01 CEST schrieb Carlos Bilbao:
> > Fix indentation of printks that start at the beginning of the line. Change
> > this for the right number of space characters, or tabs if the file uses
> > them.
> [...]
> > --- a/drivers/parisc/iosapic.c
> > +++ b/drivers/parisc/iosapic.c
> > @@ -633,7 +633,7 @@ static void iosapic_unmask_irq(struct irq_data *d)
> >   	printk("\n");
> >   }
> >
> > -printk("iosapic_enable_irq(): sel ");
> > +	printk("iosapic_enable_irq(): sel ");
> >   {
> >   	struct iosapic_info *isp = vi->iosapic;
> >
> > @@ -642,7 +642,7 @@ printk("iosapic_enable_irq(): sel ");
> >   		printk(" %x", d1);
> >   	}
> >   }
> > -printk("\n");
> > +	printk("\n");
> >   #endif
> >
> >   	/*
>
> This is also debug code. It is basically unchanged since it has been imported
> into git. So it may be time to remove the whole block. Helge?

I'd prefer to clean it proper up and keep it.


> > diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
> > index dce4cdf786cd..c3381facdfc5 100644
> > --- a/drivers/parisc/sba_iommu.c
> > +++ b/drivers/parisc/sba_iommu.c
> > @@ -1550,7 +1550,7 @@ static void sba_hw_init(struct sba_device *sba_dev)
> >
> >
> >   #if 0
> > -printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n",
> > PAGE0->mem_boot.hpa,
> > +	printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x
> > 0x%x\n", PAGE0->mem_boot.hpa, PAGE0->mem_boot.spa, PAGE0->mem_boot.pad,
> > PAGE0->mem_boot.cl_class);
> >
> >   	/*
>
> This is equally old. It should be either also removed, also this seems at
> least worth as documentation. Maybe just switch it to pr_debug() or
> dev_debug() while fixing the indentation.

Yes, I'll clean it up too.

@Carlos:
Instead of just removing or fixing the indentation, I'll fix it for both parisc
drivers. Unless you want to try...

Helge