Re: [PATCH V2 1/2] driver core: Add ability to delete device links of unregistered devices

From: Greg Kroah-Hartman
Date: Fri Jul 09 2021 - 05:55:22 EST


On Fri, Jul 09, 2021 at 09:43:40AM +0300, Adrian Hunter wrote:
> Managed device links are deleted by device_del(). However it is possible to
> add a device link to a consumer before device_add(), and then discover an
> error prevents the device from being used. In that case normally references
> to the device would be dropped and the device would be deleted. However the
> device link holds a reference to the device, so the device link and device
> remain indefinitely.

Why are you not just manually removing the link you just created? You
manually added it, you know something failed so you need to clean up, so
why not clean this up too?

thanks,

greg k-h