[bvanassche:scsi-remove-done-callback 84/84] drivers/scsi/mpi3mr/mpi3mr_os.c:412:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
From: kernel test robot
Date: Fri Jul 09 2021 - 23:41:19 EST
tree: https://github.com/bvanassche/linux scsi-remove-done-callback
head: d290e7c8d1dea1167275a28e769383e2a46b3a6b
commit: d290e7c8d1dea1167275a28e769383e2a46b3a6b [84/84] Remove the scsi_done member from struct scsi_cmnd
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/bvanassche/linux/commit/d290e7c8d1dea1167275a28e769383e2a46b3a6b
git remote add bvanassche https://github.com/bvanassche/linux
git fetch --no-tags bvanassche scsi-remove-done-callback
git checkout d290e7c8d1dea1167275a28e769383e2a46b3a6b
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/scsi/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/scsi/mpi3mr/mpi3mr_os.c: In function 'mpi3mr_flush_scmd':
>> drivers/scsi/mpi3mr/mpi3mr_os.c:412:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
412 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c: In function 'mpi3mr_process_op_reply_desc':
drivers/scsi/mpi3mr/mpi3mr_os.c:2334:6: error: 'struct scsi_cmnd' has no member named 'scsi_done'
2334 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c: In function 'mpi3mr_check_return_unmap':
drivers/scsi/mpi3mr/mpi3mr_os.c:3344:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3344 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3356:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3356 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3367:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3367 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3376:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3376 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3390:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3390 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c: In function 'mpi3mr_qcmd':
drivers/scsi/mpi3mr/mpi3mr_os.c:3460:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3460 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3467:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3467 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3481:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3481 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3486:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3486 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3493:8: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3493 | scmd->scsi_done(scmd);
| ^~
drivers/scsi/mpi3mr/mpi3mr_os.c:3508:7: error: 'struct scsi_cmnd' has no member named 'scsi_done'
3508 | scmd->scsi_done(scmd);
| ^~
vim +412 drivers/scsi/mpi3mr/mpi3mr_os.c
71e80106d05991 Kashyap Desai 2021-05-20 380
fb9b04574f1478 Kashyap Desai 2021-05-20 381 /**
fb9b04574f1478 Kashyap Desai 2021-05-20 382 * mpi3mr_flush_scmd - Flush individual SCSI command
fb9b04574f1478 Kashyap Desai 2021-05-20 383 * @rq: Block request
fb9b04574f1478 Kashyap Desai 2021-05-20 384 * @data: Adapter instance reference
ff9561e910fc59 Kashyap Desai 2021-05-20 385 * @reserved: N/A. Currently not used
fb9b04574f1478 Kashyap Desai 2021-05-20 386 *
fb9b04574f1478 Kashyap Desai 2021-05-20 387 * Return the SCSI command to the upper layers if it is in LLD
fb9b04574f1478 Kashyap Desai 2021-05-20 388 * scope.
fb9b04574f1478 Kashyap Desai 2021-05-20 389 *
fb9b04574f1478 Kashyap Desai 2021-05-20 390 * Return: true always.
fb9b04574f1478 Kashyap Desai 2021-05-20 391 */
fb9b04574f1478 Kashyap Desai 2021-05-20 392
fb9b04574f1478 Kashyap Desai 2021-05-20 393 static bool mpi3mr_flush_scmd(struct request *rq,
fb9b04574f1478 Kashyap Desai 2021-05-20 394 void *data, bool reserved)
fb9b04574f1478 Kashyap Desai 2021-05-20 395 {
fb9b04574f1478 Kashyap Desai 2021-05-20 396 struct mpi3mr_ioc *mrioc = (struct mpi3mr_ioc *)data;
fb9b04574f1478 Kashyap Desai 2021-05-20 397 struct scsi_cmnd *scmd = blk_mq_rq_to_pdu(rq);
fb9b04574f1478 Kashyap Desai 2021-05-20 398 struct scmd_priv *priv = NULL;
fb9b04574f1478 Kashyap Desai 2021-05-20 399
fb9b04574f1478 Kashyap Desai 2021-05-20 400 if (scmd) {
fb9b04574f1478 Kashyap Desai 2021-05-20 401 priv = scsi_cmd_priv(scmd);
fb9b04574f1478 Kashyap Desai 2021-05-20 402 if (!priv->in_lld_scope)
fb9b04574f1478 Kashyap Desai 2021-05-20 403 goto out;
fb9b04574f1478 Kashyap Desai 2021-05-20 404
74e1f30a286809 Kashyap Desai 2021-05-20 405 if (priv->meta_sg_valid)
74e1f30a286809 Kashyap Desai 2021-05-20 406 dma_unmap_sg(&mrioc->pdev->dev, scsi_prot_sglist(scmd),
74e1f30a286809 Kashyap Desai 2021-05-20 407 scsi_prot_sg_count(scmd), scmd->sc_data_direction);
fb9b04574f1478 Kashyap Desai 2021-05-20 408 mpi3mr_clear_scmd_priv(mrioc, scmd);
fb9b04574f1478 Kashyap Desai 2021-05-20 409 scsi_dma_unmap(scmd);
fb9b04574f1478 Kashyap Desai 2021-05-20 410 scmd->result = DID_RESET << 16;
fb9b04574f1478 Kashyap Desai 2021-05-20 411 scsi_print_command(scmd);
fb9b04574f1478 Kashyap Desai 2021-05-20 @412 scmd->scsi_done(scmd);
fb9b04574f1478 Kashyap Desai 2021-05-20 413 mrioc->flush_io_count++;
fb9b04574f1478 Kashyap Desai 2021-05-20 414 }
fb9b04574f1478 Kashyap Desai 2021-05-20 415
fb9b04574f1478 Kashyap Desai 2021-05-20 416 out:
fb9b04574f1478 Kashyap Desai 2021-05-20 417 return(true);
fb9b04574f1478 Kashyap Desai 2021-05-20 418 }
fb9b04574f1478 Kashyap Desai 2021-05-20 419
:::::: The code at line 412 was first introduced by commit
:::::: fb9b04574f147831d96b6aead161c8ca26670c97 scsi: mpi3mr: Add support for recovering controller
:::::: TO: Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>
:::::: CC: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip