Re: [PATCH v1 05/17] drm/mediatek: add mediatek-drm of vdosys0 support for MT8195

[Jason-JH Lin]

On Wed, 2021-07-07 at 12:48 +0800, CK Hu wrote:
> Hi, Jason:
> 
> On Wed, 2021-07-07 at 12:12 +0800, jason-jh.lin wrote:
> > Add mediatek-drm of vdosys0 support for MT8195.
> > 
> > Signed-off-by: jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 24
> > ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index b46bdb8985da..9074ce32912c 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > @@ -147,6 +147,23 @@ static const enum mtk_ddp_comp_id
> > mt8183_mtk_ddp_ext[] = {
> >  	DDP_COMPONENT_DPI0,
> >  };
> >  
> > +static const enum mtk_ddp_comp_id mt8195_mtk_ddp_main[] = {
> > +	DDP_COMPONENT_OVL0,
> > +	DDP_COMPONENT_RDMA0,
> > +	DDP_COMPONENT_COLOR0,
> > +	DDP_COMPONENT_CCORR,
> > +	DDP_COMPONENT_AAL0,
> > +	DDP_COMPONENT_GAMMA,
> > +	DDP_COMPONENT_DITHER,
> > +#ifdef CONFIG_MTK_DPTX_SUPPORT
> > +	DDP_COMPONENT_DSC0,
> > +	DDP_COMPONENT_MERGE0,
> > +	DDP_COMPONENT_DP_INTF0,
> > +#else
> 
> CONFIG_MTK_DPTX_SUPPORT is not defined, so remove this part.
> 
> Regards,
> CK
> 

Hi CK,

OK, I'll remove this part at the next version.

Regard,
Jason-JH.Lin

> > +	DDP_COMPONENT_DSI0,
> > +#endif
> > +};
> > +
> >  static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data
> > = {
> >  	.main_path = mt2701_mtk_ddp_main,
> >  	.main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
> > @@ -186,6 +203,11 @@ static const struct mtk_mmsys_driver_data
> > mt8183_mmsys_driver_data = {
> >  	.ext_len = ARRAY_SIZE(mt8183_mtk_ddp_ext),
> >  };
> >  
> > +static const struct mtk_mmsys_driver_data
> > mt8195_vdosys0_driver_data = {
> > +	.main_path = mt8195_mtk_ddp_main,
> > +	.main_len = ARRAY_SIZE(mt8195_mtk_ddp_main),
> > +};
> > +
> >  static int mtk_drm_kms_init(struct drm_device *drm)
> >  {
> >  	struct mtk_drm_private *private = drm->dev_private;
> > @@ -468,6 +490,8 @@ static const struct of_device_id
> > mtk_drm_of_ids[] = {
> >  	  .data = &mt8173_mmsys_driver_data},
> >  	{ .compatible = "mediatek,mt8183-mmsys",
> >  	  .data = &mt8183_mmsys_driver_data},
> > +	{.compatible = "mediatek,mt8195-vdosys0",
> > +	  .data = &mt8195_vdosys0_driver_data},
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(of, mtk_drm_of_ids);
> 
>