Re: [PATCH v1 12/17] drm/mediatek: add CCORR support for MT8195

[Jason-JH Lin]

On Wed, 2021-07-07 at 14:02 +0800, CK Hu wrote:
> Hi, Jason:
> 
> On Wed, 2021-07-07 at 12:12 +0800, jason-jh.lin wrote:
> > Add CCORR support for MT8195.
> > 
> > Signed-off-by: jason-jh.lin <jason-jh.lin@xxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 ++
> >  drivers/gpu/drm/mediatek/mtk_drm_drv.c    | 2 ++
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
> > b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
> > index 141cb36b9c07..8188b220cc6d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c
> > @@ -208,6 +208,8 @@ static const struct mtk_disp_ccorr_data
> > mt8183_ccorr_driver_data = {
> >  static const struct of_device_id mtk_disp_ccorr_driver_dt_match[]
> > = {
> >  	{ .compatible = "mediatek,mt8183-disp-ccorr",
> >  	  .data = &mt8183_ccorr_driver_data},
> > +	{ .compatible = "mediatek,mt8195-disp-ccorr",
> > +	  .data = &mt8183_ccorr_driver_data},
> >  	{},
> >  };
> >  MODULE_DEVICE_TABLE(of, mtk_disp_ccorr_driver_dt_match);
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index 28bf4a11efb0..058b50d0e64b 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > @@ -440,6 +440,8 @@ static const struct of_device_id
> > mtk_ddp_comp_dt_ids[] = {
> >  	  .data = (void *)MTK_DISP_WDMA },
> >  	{ .compatible = "mediatek,mt8183-disp-ccorr",
> >  	  .data = (void *)MTK_DISP_CCORR },
> > +	{ .compatible = "mediatek,mt8195-disp-ccorr",
> > +	  .data = (void *)MTK_DISP_CCORR },
> 
> The same question as OVL and COLOR.
> 
> Regards,
> CK
> 
Hi CK,

OK, I'll remove this patch at the next version.

Regard,
Jason-JH.Lin
> >  	{ .compatible = "mediatek,mt2701-disp-color",
> >  	  .data = (void *)MTK_DISP_COLOR },
> >  	{ .compatible = "mediatek,mt8173-disp-color",
> 
>