Re: [External] [PATCH v3 3/3] mm, memcg: inline swap-related functions to improve disabled memcg config

[Muchun Song]

On Sat, Jul 10, 2021 at 8:36 AM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote:
>
> Inline mem_cgroup_try_charge_swap, mem_cgroup_uncharge_swap and
> cgroup_throttle_swaprate functions to perform mem_cgroup_disabled static
> key check inline before calling the main body of the function. This
> minimizes the memcg overhead in the pagefault and exit_mmap paths when
> memcgs are disabled using cgroup_disable=memory command-line option.
> This change results in ~1% overhead reduction when running PFT test
> comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory}
> configuration on an 8-core ARM64 Android device.
>
> Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
> Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>

LGTM.

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

Thanks.