Re: [PATCH net-next v5] net: phy: intel-xway: Add RGMII internal delay configuration

From: Martin Blumenstingl
Date: Mon Jul 12 2021 - 07:12:36 EST


On Mon, Jul 12, 2021 at 9:24 AM Martin Schiller <ms@xxxxxxxxxx> wrote:
>
> This adds the possibility to configure the RGMII RX/TX clock skew via
> devicetree.
>
> Simply set phy mode to "rgmii-id", "rgmii-rxid" or "rgmii-txid" and add
> the "rx-internal-delay-ps" or "tx-internal-delay-ps" property to the
> devicetree.
>
> Furthermore, a warning is now issued if the phy mode is configured to
> "rgmii" and an internal delay is set in the phy (e.g. by pin-strapping),
> as in the dp83867 driver.
>
> Signed-off-by: Martin Schiller <ms@xxxxxxxxxx>
Thanks for this updated version!
Everything's looking good so:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>