Re: [PATCH] mm: Make copy_huge_page() always available

From: Mina Almasry
Date: Mon Jul 12 2021 - 15:33:00 EST


On Mon, Jul 12, 2021 at 10:52 AM Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:
>
> On 7/12/21 8:32 AM, Matthew Wilcox (Oracle) wrote:
> > Rewrite copy_huge_page() and move it into mm/util.c so it's always
> > available. Fixes an exposure of uninitialised memory on configurations
> > with HUGETLB and UFFD enabled and MIGRATION disabled.
> >
> > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY")
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Reviewed-By: Mina Almasry <almasrymina@xxxxxxxxxx>

> > ---
> > include/linux/migrate.h | 5 -----
> > include/linux/mm.h | 1 +
> > mm/migrate.c | 48 -----------------------------------------
> > mm/util.c | 10 +++++++++
> > 4 files changed, 11 insertions(+), 53 deletions(-)
>
> Thanks Matthew,
>
> Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> --
> Mike Kravetz