Re: [PATCH] tools: PCI: Zero-initialize param

[Shunyong Yang]

Hi,  Romanovsky,

On 2021/7/11 19:56, Leon Romanovsky wrote:
> On Sun, Jul 11, 2021 at 09:48:17AM +0800, Shunyong Yang wrote:
> > Hi, Bjorn and Kishon,
> >
> >    Gentle ping. Would you please help to review and merge this tiny change?
> >
> > Thansk.
> >
> > Shunyong.
> >
> > On 2021/6/27 8:39, Shunyong Yang wrote:
> > > The values in param may be random if they are not initialized, which
> > > may cause use_dma flag set even when "-d" option is not provided
> > > in command line. Initializing all members to 0 to solve this.
> > >
> > > Signed-off-by: Shunyong Yang <yang.shunyong@xxxxxxxxx>
> > > ---
> > >    tools/pci/pcitest.c | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> > > index 0a1344c45213..59bcd6220a58 100644
> > > --- a/tools/pci/pcitest.c
> > > +++ b/tools/pci/pcitest.c
> > > @@ -40,7 +40,7 @@ struct pci_test {
> > >    static int run_test(struct pci_test *test)
> > >    {
> > > -	struct pci_endpoint_test_xfer_param param;
> > > +	struct pci_endpoint_test_xfer_param param = {0};
> You can simply write {} instead of {0} - zero is not needed.
>
> Thanks

   Will change as you said.

Thanks.

Shunyong.

> > >    	int ret = -EINVAL;
> > >    	int fd;