Re: [PATCHv6 1/3] dt-bindings: misc: ge-achc: Convert to DT schema format
From: Rob Herring
Date: Tue Jul 13 2021 - 10:03:19 EST
On Mon, 12 Jul 2021 17:02:40 +0200, Sebastian Reichel wrote:
> Convert the binding to DT schema format. Also update the binding
> to fix shortcomings
>
> * Add "nxp,kinetis-k20" fallback compatible
> * add programming SPI interface and reset GPIO
> * add main clock
> * add voltage supplies
> * drop spi-max-frequency from required properties,
> driver will setup max. frequency
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/misc/ge-achc.txt | 26 --------
> .../devicetree/bindings/misc/ge-achc.yaml | 65 +++++++++++++++++++
> 2 files changed, 65 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/misc/ge-achc.txt
> create mode 100644 Documentation/devicetree/bindings/misc/ge-achc.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/ge-achc.example.dt.yaml: spi: spi@1:reg: [[1], [0]] is too long
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-controller.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/ge-achc.example.dt.yaml: spi: spi@1:reg: Additional items are not allowed ([0] was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-controller.yaml
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1504037
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.