Re: [PATCH v3] kdb: Get rid of custom debug heap allocator

[Daniel Thompson]

On Tue, Jul 13, 2021 at 06:45:52AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Jul 13, 2021 at 4:24 AM Sumit Garg <sumit.garg@xxxxxxxxxx> wrote:
> >
> > > >  int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
> > > >  {
> > > >         int ret = 0;
> > > >         unsigned long symbolsize = 0;
> > > >         unsigned long offset = 0;
> > > > -#define knt1_size 128          /* must be >= kallsyms table size */
> > > > -       char *knt1 = NULL;
> > > > +       static char namebuf[KSYM_NAME_LEN];
> > >
> > > I guess this also ends up fixing a bug too, right? My greps show that
> > > "KSYM_NAME_LEN" is 512
> >
> > I can see "KSYM_NAME_LEN" defined as 128 here [1]. Are you looking at
> > any other header file?
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/kallsyms.h#n18
> 
> Ah ha, it's recent! See commit f2f6175186f4 ("kallsyms: increase
> maximum kernel symbol length to 512")

Ineed. So recent that I think it hasn't been merged to mainline yet!

This patch is part of the rust patch set. IIUC it is in linux-next for
wider testing but I'd be surprised if it gets merged to mainline anytime
soon (and even more amazed if it is merged without being rebased and
given a new hash value ;-) ).


Daniel.