Re: [PATCH] RCU: Fix macro name CONFIG_TASKS_RCU_TRACE

From: Paul E. McKenney
Date: Tue Jul 13 2021 - 11:19:10 EST


On Tue, Jul 13, 2021 at 06:18:12AM -0700, Paul E. McKenney wrote:
> On Tue, Jul 13, 2021 at 09:09:04AM -0400, Mathieu Desnoyers wrote:
> > ----- On Jul 13, 2021, at 12:16 AM, paulmck paulmck@xxxxxxxxxx wrote:
> >
> > > On Tue, Jul 13, 2021 at 08:56:45AM +0800, zhouzhouyi@xxxxxxxxx wrote:
> > >> From: Zhouyi Zhou <zhouzhouyi@xxxxxxxxx>
> > >>
> > >> Hi Paul,
> > >>
> > >> During my studying of RCU, I did a grep in the kernel source tree.
> > >> I found there are 3 places where the macro name CONFIG_TASKS_RCU_TRACE
> > >> should be CONFIG_TASKS_TRACE_RCU instead.
> > >>
> > >> Without memory fencing, the idle/userspace task inspection may not
> > >> be so accurate.
> > >>
> > >> Thanks for your constant encouragement for my studying.
> > >>
> > >> Best Wishes
> > >> Zhouyi
> > >>
> > >> Signed-off-by: Zhouyi Zhou <zhouzhouyi@xxxxxxxxx>
> > >
> > > Good eyes, and those could cause real bugs, so thank you!
> >
> > Hi Paul,
> >
> > This makes me wonder: what is missing testing-wise in rcutorture to
> > catch those issues with testing before they reach mainline ?
>
> My guess: Running on weakly ordered architectures. ;-)

And another guess: A tool that identifies use of Kconfig options
that are not defined in any Kconfig* file.

Thanx, Paul