[hch-misc:follow_pfn 1/3] drivers/media/common/videobuf2/videobuf2-dma-contig.c:539:1: warning: unused label 'out'

From: kernel test robot
Date: Tue Jul 13 2021 - 11:33:00 EST

tree: git://git.infradead.org/users/hch/misc.git follow_pfn head: 66855f59863300731d08162e8d20d951b0827e28
commit: ba9792af6d1881f3e5fffbdd8b2308d854217878 [1/3] config: arm-buildonly-randconfig-r001-20210713 (attached compiler: clang version 13.0.0 (.config.gz< Description: application/gzip Michael S. Tsirkin: "Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver" Anders Roxell: "Re: perf: bench/sched-messaging.c:73:13: error: 'dummy' may be used uninitialized" kernel test robot: "[hch-misc:follow_pfn 1/3] drivers/media/common/videobuf2/videobuf2-dma-contig.c:539:1: warning: unused label 'out'" date ] [ thread ] [ subject ] [ author ]
media: videobuf2: remove userptr support
as .config)
s://github.com/llvm/llvm-project">https://github.com/llvm/llvm-project 8d69635ed9ecf36fd0ca85906bfde17949671cbe)
ontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
build
/hch/misc.git

make.cross ARCH=arm

warning: unused variable 'i' [-Wunused-variable]
warning: unused label 'out' [-Wunused-label]
ontig.c
Tomasz Stanislawski 2012-06-14 461
Hans Verkuil 2016-04-15 462 static void *vb2_dc_get_userptr(struct device *dev, unsigned long vaddr,
Hans Verkuil 2014-11-18 463 unsigned long size, enum dma_data_direction dma_dir)
Pawel Osciak 2010-10-11 464 {
Pawel Osciak 2010-10-11 465 struct vb2_dc_buf *buf;
Jan Kara 2015-07-13 466 struct frame_vector *vec;
Tvrtko Ursulin 2017-07-31 467 unsigned int offset;
Jan Kara 2015-07-13 468 int n_pages, i;
Tomasz Stanislawski 2012-06-14 469 int ret = 0;
Tomasz Stanislawski 2012-06-14 470 struct sg_table *sgt;
Tomasz Stanislawski 2012-06-14 471 unsigned long contig_size;
Marek Szyprowski 2012-06-12 472 unsigned long dma_align = dma_get_cache_alignment();
Marek Szyprowski 2012-06-12 473
Marek Szyprowski 2012-06-12 474 /* Only cache aligned DMA transfers are reliable */
Marek Szyprowski 2012-06-12 475 if (!IS_ALIGNED(vaddr | size, dma_align)) {
Marek Szyprowski 2012-06-12 476 pr_debug("user data must be aligned to %lu bytes\n", dma_align);
Marek Szyprowski 2012-06-12 477 return ERR_PTR(-EINVAL);
Marek Szyprowski 2012-06-12 478 }
Marek Szyprowski 2012-06-12 479
Marek Szyprowski 2012-06-12 480 if (!size) {
Marek Szyprowski 2012-06-12 481 pr_debug("size is zero\n");
Marek Szyprowski 2012-06-12 482 return ERR_PTR(-EINVAL);
Marek Szyprowski 2012-06-12 483 }
Pawel Osciak 2010-10-11 484
Hans Verkuil 2016-07-21 485 if (WARN_ON(!dev))
Hans Verkuil 2016-07-21 486 return ERR_PTR(-EINVAL);
Hans Verkuil 2016-07-21 487
Pawel Osciak 2010-10-11 488 buf = kzalloc(sizeof *buf, GFP_KERNEL);
Pawel Osciak 2010-10-11 489 if (!buf)
Pawel Osciak 2010-10-11 490 return ERR_PTR(-ENOMEM);
Pawel Osciak 2010-10-11 491
Hans Verkuil 2016-04-15 492 buf->dev = dev;
Hans Verkuil 2014-11-18 493 buf->dma_dir = dma_dir;
Tomasz Stanislawski 2012-06-14 494
Tvrtko Ursulin 2017-07-31 495 offset = lower_32_bits(offset_in_page(vaddr));
Hans Verkuil 2019-04-04 496 vec = vb2_create_framevec(vaddr, size);
Jan Kara 2015-07-13 497 if (IS_ERR(vec)) {
Jan Kara 2015-07-13 498 ret = PTR_ERR(vec);
Tomasz Stanislawski 2012-06-14 499 goto fail_buf;
Tomasz Stanislawski 2012-06-14 500 }
Jan Kara 2015-07-13 501 buf->vec = vec;
Jan Kara 2015-07-13 502 n_pages = frame_vector_count(vec);
Tomasz Stanislawski 2012-06-14 503
Tomasz Stanislawski 2012-06-14 504 sgt = kzalloc(sizeof(*sgt), GFP_KERNEL);
Tomasz Stanislawski 2012-06-14 505 if (!sgt) {
Tomasz Stanislawski 2012-06-14 506 pr_err("failed to allocate sg table\n");
Tomasz Stanislawski 2012-06-14 507 ret = -ENOMEM;
Jan Kara 2015-07-13 508 goto fail_pfnvec;
Pawel Osciak 2010-10-11 509 }
Pawel Osciak 2010-10-11 510
Christoph Hellwig 2021-07-13 511 ret = sg_alloc_table_from_pages(sgt, vec->pages, n_pages,
Tomasz Stanislawski 2012-06-14 512 offset, size, GFP_KERNEL);
Tomasz Stanislawski 2012-06-14 513 if (ret) {
Tomasz Stanislawski 2012-06-14 514 pr_err("failed to initialize sg table\n");
Tomasz Stanislawski 2012-06-14 515 goto fail_sgt;
Tomasz Stanislawski 2012-06-14 516 }
Tomasz Stanislawski 2012-06-14 517
Hans Verkuil 2014-11-18 518 /*
Hans Verkuil 2014-11-18 519 * No need to sync to the device, this will happen later when the
Hans Verkuil 2014-11-18 520 * prepare() memop is called.
Hans Verkuil 2014-11-18 521 */
Marek Szyprowski 2020-09-04 522 if (dma_map_sgtable(buf->dev, sgt, buf->dma_dir,
Marek Szyprowski 2020-09-04 523 DMA_ATTR_SKIP_CPU_SYNC)) {
Tomasz Stanislawski 2012-06-14 524 pr_err("failed to map scatterlist\n");
Tomasz Stanislawski 2012-06-14 525 ret = -EIO;
Tomasz Stanislawski 2012-06-14 526 goto fail_sgt_init;
Tomasz Stanislawski 2012-06-14 527 }
Tomasz Stanislawski 2012-06-14 528
Tomasz Stanislawski 2012-06-14 529 contig_size = vb2_dc_get_contiguous_size(sgt);
Tomasz Stanislawski 2012-06-14 530 if (contig_size < size) {
Tomasz Stanislawski 2012-06-14 531 pr_err("contiguous mapping is too small %lu/%lu\n",
Tomasz Stanislawski 2012-06-14 532 contig_size, size);
Tomasz Stanislawski 2012-06-14 533 ret = -EFAULT;
Tomasz Stanislawski 2012-06-14 534 goto fail_map_sg;
Tomasz Stanislawski 2012-06-14 535 }
Tomasz Stanislawski 2012-06-14 536
Tomasz Stanislawski 2012-06-14 537 buf->dma_addr = sg_dma_address(sgt->sgl);
Tomasz Stanislawski 2012-06-14 538 buf->dma_sgt = sgt;
Jan Kara 2015-07-13 @539 out:
Jan Kara 2015-07-13 540 buf->size = size;
Pawel Osciak 2010-10-11 541
Pawel Osciak 2010-10-11 542 return buf;
Pawel Osciak 2010-10-11 543
Tomasz Stanislawski 2012-06-14 544 fail_map_sg:
Marek Szyprowski 2020-09-04 545 dma_unmap_sgtable(buf->dev, sgt, buf->dma_dir, DMA_ATTR_SKIP_CPU_SYNC);
Pawel Osciak 2010-10-11 546
Tomasz Stanislawski 2012-06-14 547 fail_sgt_init:
Tomasz Stanislawski 2012-06-14 548 sg_free_table(sgt);
Tomasz Stanislawski 2012-06-14 549
Tomasz Stanislawski 2012-06-14 550 fail_sgt:
Tomasz Stanislawski 2012-06-14 551 kfree(sgt);
Tomasz Stanislawski 2012-06-14 552
Jan Kara 2015-07-13 553 fail_pfnvec:
Jan Kara 2015-07-13 554 vb2_destroy_framevec(vec);
Tomasz Stanislawski 2012-06-14 555
Tomasz Stanislawski 2012-06-14 556 fail_buf:
Pawel Osciak 2010-10-11 557 kfree(buf);
Tomasz Stanislawski 2012-06-14 558
Tomasz Stanislawski 2012-06-14 559 return ERR_PTR(ret);
Pawel Osciak 2010-10-11 560 }
Pawel Osciak 2010-10-11 561
commit
media: vb2: Convert vb2_dc_get_userptr() to use frame vector
gt;
/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
br>

Next message: Michael S. Tsirkin: "Re: [PATCH v14] i2c: virtio: add a virtio i2c frontend driver"
Previous message: Anders Roxell: "Re: perf: bench/sched-messaging.c:73:13: error: 'dummy' may be used uninitialized"
In reply to: kernel test robot: "[hch-misc:follow_pfn 1/3] drivers/media/common/videobuf2/videobuf2-dma-contig.c:539:1: warning: unused label 'out'"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]