[PATCH] media: usb: fix memory leak in stk_camera_probe

From: Dongliang Mu
Date: Tue Jul 13 2021 - 23:23:58 EST


stk_camera_probe mistakenly execute usb_get_intf and increase the
refcount of interface->dev.

Fix this by removing the execution of usb_get_intf.

Reported-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
Fixes: 0aa77f6c2954 ("[media] move the remaining USB drivers to drivers/media/usb")
Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
---
drivers/media/usb/stkwebcam/stk-webcam.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c
index a45d464427c4..5bd8e85b9452 100644
--- a/drivers/media/usb/stkwebcam/stk-webcam.c
+++ b/drivers/media/usb/stkwebcam/stk-webcam.c
@@ -1311,7 +1311,6 @@ static int stk_camera_probe(struct usb_interface *interface,

dev->udev = udev;
dev->interface = interface;
- usb_get_intf(interface);

if (hflip != -1)
dev->vsettings.hflip = hflip;
--
2.25.1