Re: [PATCH 5.10 007/593] ALSA: usb-audio: scarlett2: Fix wrong resume call

[Takashi Iwai]

On Tue, 13 Jul 2021 22:46:43 +0200,
Pavel Machek wrote:
> 
> Hi!
> 
> > This patch corrects those issues.  It introduces a new value type,
> > USB_MIXER_BESPOKEN, which indicates a non-standard mixer element, and
> > use this type for all scarlett2 mixer elements, as well as
> > initializing the fixed unit id 0 for avoiding the overflow.
> 
> New mixer value is introduced, but printing code in mixer.c is not
> updated.
> 
> Is something like this needed?

Currently BESPOKEN type doesn't use the standard dump callback, hence
this won't hit, but such a change wouldn't hurt.


thanks,

Takashi

> 
> 
> > +++ b/sound/usb/mixer.h
> > @@ -55,6 +55,7 @@ enum {
> >  	USB_MIXER_U16,
> >  	USB_MIXER_S32,
> >  	USB_MIXER_U32,
> > +	USB_MIXER_BESPOKEN,	/* non-standard type */
> >  };
> >
> 
> Best regards,
> 							Pavel
> 
> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> index 2b5281ef8fca..83d5e4d19128 100644
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -3294,7 +3294,7 @@ static void snd_usb_mixer_dump_cval(struct snd_info_buffer *buffer,
>  {
>  	struct usb_mixer_elem_info *cval = mixer_elem_list_to_info(list);
>  	static const char * const val_types[] = {
> -		"BOOLEAN", "INV_BOOLEAN", "S8", "U8", "S16", "U16", "S32", "U32",
> +		"BOOLEAN", "INV_BOOLEAN", "S8", "U8", "S16", "U16", "S32", "U32", "BESPOKEN", 
>  	};
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> [2 Digital signature <application/pgp-signature (7bit)>]
>