Re: [PATCH v4 1/4] fpga: dfl: expose feature revision from struct dfl_device

[Tom Rix]

On 7/14/21 4:14 AM, Martin Hundebøll wrote:
> On 06/07/2021 16.10, Tom Rix wrote:
> > > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
> > > index 511b20ff35a3..9381c579d1cd 100644
> > > --- a/drivers/fpga/dfl.c
> > > +++ b/drivers/fpga/dfl.c
> > > @@ -381,6 +381,7 @@ dfl_dev_add(struct dfl_feature_platform_data 
> > > *pdata,
> > >       ddev->type = feature_dev_id_type(pdev);
> > >       ddev->feature_id = feature->id;
> > > +    ddev->revision = feature->revision;
> > >       ddev->cdev = pdata->dfl_cdev;
> > >       /* add mmio resource */
> > > @@ -717,6 +718,7 @@ struct build_feature_devs_info {
> > >    */
> > >   struct dfl_feature_info {
> > >       u16 fid;
> > > +    u8 rev;
> >
> > In other places 'revision' is the element name.
> >
> > For consistency, change rev to revision
>
> So is fid vs. feature. I deliberately chose 'rev' to be consistent
> with other elements in struct dfl_feature_info.

Consistence for revision is important because we want to make it easy 
for folks using grep to search for one string not several.

fid vs feature_id is a problem, but one you do not need to solve.

Tom


> // Martin