Re: [PATCH V1 net-next 2/5] dt-bindings: fec: add RGMII delayed clock property
From: Andrew Lunn
Date: Wed Jul 14 2021 - 19:34:23 EST
On Wed, Jul 14, 2021 at 05:19:37PM -0600, Rob Herring wrote:
> On Fri, Jul 09, 2021 at 04:18:20PM +0800, Joakim Zhang wrote:
> > From: Fugang Duan <fugang.duan@xxxxxxx>
> >
> > Add property for RGMII delayed clock.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@xxxxxxx>
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> > ---
> > Documentation/devicetree/bindings/net/fsl-fec.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt
> > index 6754be1b91c4..f93b9552cfc5 100644
> > --- a/Documentation/devicetree/bindings/net/fsl-fec.txt
> > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
> > @@ -50,6 +50,10 @@ Optional properties:
> > SOC internal PLL.
> > - "enet_out"(option), output clock for external device, like supply clock
> > for PHY. The clock is required if PHY clock source from SOC.
> > + - "enet_2x_txclk"(option), for RGMII sampleing clock which fixed at 250Mhz.
> > + The clock is required if SOC RGMII enable clock delay.
> > +- fsl,rgmii_txc_dly: add RGMII TXC delayed clock from MAC.
> > +- fsl,rgmii_rxc_dly: add RGMII RXC delayed clock from MAC.
>
> Don't we have standard properties for this?
Yes, rx-internal-delay-ps and tx-internal-delay-ps defined in
ethernet-controller.yaml
Andrew