Re: [PATCH 4/4] Revert "mm/page_alloc: make should_fail_alloc_page() static"

From: Christoph Hellwig
Date: Thu Jul 15 2021 - 02:36:04 EST


On Tue, Jul 13, 2021 at 02:56:25PM +0100, Mel Gorman wrote:
> From: Matteo Croce <mcroce@xxxxxxxxxxxxx>
>
> This reverts commit f7173090033c70886d925995e9dfdfb76dbb2441.
>
> Fix an unresolved symbol error when CONFIG_DEBUG_INFO_BTF=y:

I still fundamentally disagreed with this "fix". Whatever code requires
a function to be non-static without a prototype and reference is
completely fucked up beyond rescue and needs to be disabled util
it can be fixed instead of worked around like this.