Re: [PATCH 2/4] vp_vdpa: Fix return value check for vdpa_alloc_device()

[Jason Wang]

在 2021/7/15 下午4:00, Xie Yongji 写道:
> The vdpa_alloc_device() returns an error pointer upon
> failure, not NULL. To handle the failure correctly, this
> replaces NULL check with IS_ERR() check and propagate the
> error upwards.
>
> Fixes: 64b9f64f80a6 ("vdpa: introduce virtio pci driver")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Xie Yongji <xieyongji@xxxxxxxxxxxxx>


Acked-by: Jason Wang <jasowang@xxxxxxxxxx>


> ---
>   drivers/vdpa/virtio_pci/vp_vdpa.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index 7b4a6396c553..fe0527329857 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -436,9 +436,9 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   
>   	vp_vdpa = vdpa_alloc_device(struct vp_vdpa, vdpa,
>   				    dev, &vp_vdpa_ops, NULL);
> -	if (vp_vdpa == NULL) {
> +	if (IS_ERR(vp_vdpa)) {
>   		dev_err(dev, "vp_vdpa: Failed to allocate vDPA structure\n");
> -		return -ENOMEM;
> +		return PTR_ERR(vp_vdpa);
>   	}
>   
>   	mdev = &vp_vdpa->mdev;