Re: [PATCH 5.12] selftests/resctrl: Fix incorrect parsing of option "-t"

[Greg KH]

On Mon, Jul 12, 2021 at 03:55:23PM +0800, Xiaochen Shen wrote:
> commit 1421ec684a43379b2aa3cfda20b03d38282dc990 upstream.
> 
> Resctrl test suite accepts command line argument "-t" to specify the
> unit tests to run in the test list (e.g., -t mbm,mba,cmt,cat) as
> documented in the help.
> 
> When calling strtok() to parse the option, the incorrect delimiters
> argument ":\t" is used. As a result, passing "-t mbm,mba,cmt,cat" throws
> an invalid option error.
> 
> Fix this by using delimiters argument "," instead of ":\t" for parsing
> of unit tests list. At the same time, remove the unnecessary "spaces"
> between the unit tests in help documentation to prevent confusion.
> 
> Fixes: 790bf585b0ee ("selftests/resctrl: Add Cache Allocation Technology (CAT) selftest")
> Fixes: 78941183d1b1 ("selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest")
> Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test")
> Fixes: 034c7678dd2c ("selftests/resctrl: Add README for resctrl tests")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Xiaochen Shen <xiaochen.shen@xxxxxxxxx>
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>
> Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> ---
>  tools/testing/selftests/resctrl/README          | 2 +-
>  tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 

Both now queued up, thanks.

greg k-h