Re: [PATCH v6 RESEND 2/3] drm/mediatek: init panel orientation property
From: Enric Balletbo Serra
Date: Thu Jul 15 2021 - 07:09:57 EST
Hi Hsin-Yi,
Thank you for your patch.
Missatge de Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> del dia dj., 24 de juny
2021 a les 12:55:
>
> Init panel orientation property after connector is initialized. Let the
> panel driver decides the orientation value later.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> Acked-by: Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>
Tested-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
As together with the other two patches works and I don't see any
problem on the Lenovo IdeaPad Duet, and the panel has the proper
orientation
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index ae403c67cbd92..9da1fd6491319 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -964,6 +964,13 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi)
> ret = PTR_ERR(dsi->connector);
> goto err_cleanup_encoder;
> }
> +
> + ret = drm_connector_init_panel_orientation_property(dsi->connector);
> + if (ret) {
> + DRM_ERROR("Unable to init panel orientation\n");
> + goto err_cleanup_encoder;
> + }
> +
> drm_connector_attach_encoder(dsi->connector, &dsi->encoder);
>
> return 0;
> --
> 2.32.0.288.g62a8d224e6-goog
>