[mcgrof-next:20210708-block-fixes-v2 30/89] drivers/block/paride/pcd.c:1039:5: error: label 'pcd_cleanup_disks' used but not defined

From: kernel test robot
Date: Thu Jul 15 2021 - 10:02:58 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210708-block-fixes-v2
head: db0174e39de7dc941f158ce53ee3af95b1635b62
commit: 9269ac480e815943f78054c276117d8300d92854 [30/89] paride/pcd: capture errors on cdrom_register()
config: arm-randconfig-r003-20210715 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=9269ac480e815943f78054c276117d8300d92854
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20210708-block-fixes-v2
git checkout 9269ac480e815943f78054c276117d8300d92854
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/block/paride/pcd.c: In function 'pcd_init':
>> drivers/block/paride/pcd.c:1039:5: error: label 'pcd_cleanup_disks' used but not defined
1039 | goto pcd_cleanup_disks;
| ^~~~


vim +/pcd_cleanup_disks +1039 drivers/block/paride/pcd.c

1013
1014 static int __init pcd_init(void)
1015 {
1016 struct pcd_unit *cd;
1017 int unit;
1018 int err;
1019
1020 if (disable)
1021 return -EINVAL;
1022
1023 pcd_init_units();
1024
1025 if (pcd_detect())
1026 return -ENODEV;
1027
1028 /* get the atapi capabilities page */
1029 pcd_probe_capabilities();
1030
1031 err = register_blkdev(major, name);
1032 if (err)
1033 goto out_cleanup_disk;
1034
1035 for (unit = 0, cd = pcd; unit < PCD_UNITS; unit++, cd++) {
1036 if (cd->present) {
1037 err = register_cdrom(cd->disk, &cd->info);
1038 if (err)
> 1039 goto pcd_cleanup_disks;
1040 cd->disk->private_data = cd;
1041 err = add_disk(cd->disk);
1042 if (err)
1043 goto out_cleanup_disk;
1044 }
1045 }
1046
1047 return 0;
1048
1049 out_cleanup_disk:
1050 pcd_cleanup_disks();
1051 return err;
1052 }
1053

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip