Re: [PATCH 1/3] arm: Rename PMD_ORDER to PMD_TABLE_ORDER

From: Russell King (Oracle)
Date: Thu Jul 15 2021 - 12:47:49 EST


On Thu, Jul 15, 2021 at 02:46:10PM +0100, Matthew Wilcox (Oracle) wrote:
> This is the order of the page table allocation, not the order of a PMD.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> ---
> arch/arm/kernel/head.S | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S
> index 9eb0b4dbcc12..6da39a1d70ba 100644
> --- a/arch/arm/kernel/head.S
> +++ b/arch/arm/kernel/head.S
> @@ -38,10 +38,10 @@
> #ifdef CONFIG_ARM_LPAE
> /* LPAE requires an additional page for the PGD */
> #define PG_DIR_SIZE 0x5000
> -#define PMD_ORDER 3
> +#define PMD_TABLE_ORDER 3
> #else
> #define PG_DIR_SIZE 0x4000
> -#define PMD_ORDER 2
> +#define PMD_TABLE_ORDER 2

I think PMD_ENTRY_ORDER would make more sense here - this is the
power-of-2 of an individual PMD entry, not of the entire table.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!