Re: [PATCH v1 1/4] mm/memory_hotplug: use "unsigned long" for PFN in zone_for_pfn_range()
From: Andrew Morton
Date: Thu Jul 15 2021 - 14:12:45 EST
On Thu, 15 Jul 2021 11:42:21 +0200 David Hildenbrand <david@xxxxxxxxxx> wrote:
> > I'd propose to add Cc: <stable@xxxxxxxxxxxxxxx> since I actually had
> > the fun to try to debug something like this a couple of years ago:
> > 6cdb18ad98a4 ("mm/vmstat: fix overflow in mod_zone_page_state()")
> >
>
> Good point, and thinking again what can go wrong, I tend to agree. We
> are trying to keep zones contiguous and it could happen that we end up
> with something like ZONE_DMA here (via default_kernel_zone_for_pfn())
> and would consequently online something to ZONE_DMA that doesn't belong
> there, resulting in crashes.
>
> @Andrew can you add Cc: <stable@xxxxxxxxxxxxxxx> and
>
> "As we will search for a fitting zone using the wrong pfn, we might end
> up onlining memory to one of the special kernel zones, such as ZONE_DMA,
> which can end badly as the onlined memory does not satisfy properties of
> these zones."
Yep, all done.