Re: [PATCH -next v2] sched: Dec cfs_bandwith_used in destroy_cfs_bandwidth()
From: Daniel Jordan
Date: Thu Jul 15 2021 - 16:29:31 EST
Only nits left from my side anyway. Looks fine otherwise!
There are a couple typos in the subject and changelog, cfs_bandwith_used
and cfs_bandwith_uesd.
On Thu, Jul 15, 2021 at 07:24:33PM +0800, Zhang Qiao wrote:
> +
> +void cfs_bandwidth_usage_inc(void)
> +{
> + static_key_slow_inc(&__cfs_bandwidth_used);
> +}
Nothing calls this, and getting rid of it would potentially avoid a
janitorial patch later.
> +void cfs_bandwidth_usage_dec(void)
static void cfs_bandwidth_usage_dec(void)
> void cfs_bandwidth_usage_inc(void) {}
> void cfs_bandwidth_usage_dec(void) {}
static void cfs_bandwidth_usage_dec(void) {}
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> extern void cfs_bandwidth_usage_inc(void);
> extern void cfs_bandwidth_usage_dec(void);
These would then go away.