Re: [PATCH 18/20] perf trace: free strings in trace__parse_events_option
From: Arnaldo Carvalho de Melo
Date: Thu Jul 15 2021 - 16:36:24 EST
Em Thu, Jul 15, 2021 at 06:07:23PM +0200, Riccardo Mancini escreveu:
> ASan reports several memory leaks running the perf test
> "88: Check open filename arg using perf trace + vfs_getname".
> The fourth of these leaks is related to some strings never being freed
> in trace__parse_events_option.
>
> This patch adds the missing frees.
Thanks, applied.
- Arnaldo
> Signed-off-by: Riccardo Mancini <rickyman7@xxxxxxxxx>
> ---
> tools/perf/builtin-trace.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index d9c65d55a9ae7526..4a677f3ff273887a 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -4659,6 +4659,9 @@ static int trace__parse_events_option(const struct option *opt, const char *str,
> err = parse_events_option(&o, lists[0], 0);
> }
> out:
> + free(strace_groups_dir);
> + free(lists[0]);
> + free(lists[1]);
> if (sep)
> *sep = ',';
>
> --
> 2.31.1
>
--
- Arnaldo