Re: [PATCH 1/6] HID: hid-input: Add offhook and ring LEDs for headsets

[Pavel Machek]

On Thu 2021-07-15 13:39:26, Dmitry Torokhov wrote:
> On Thu, Jul 15, 2021 at 08:57:44PM +0200, Jiri Kosina wrote:
> > On Tue, 6 Jul 2021, Benjamin Tissoires wrote:
> > 
> > > > A lot of USBHID headsets available on the market have LEDs that indicate
> > > > ringing and off-hook states when used with VoIP applications. This
> > > > commit exposes these LEDs via the standard sysfs interface.

> > > > diff --git a/drivers/input/input-leds.c b/drivers/input/input-leds.c
> > > > index 0b11990ade46..bc6e25b9af25 100644
> > > > --- a/drivers/input/input-leds.c
> > > > +++ b/drivers/input/input-leds.c
> > > > @@ -33,6 +33,8 @@ static const struct {
> > > >         [LED_MISC]      = { "misc" },
> > > >         [LED_MAIL]      = { "mail" },
> > > >         [LED_CHARGING]  = { "charging" },
> > > > +       [LED_OFFHOOK]   = { "offhook" },
> > > 
> > > I am pretty sure this also needs to be reviewed by the led folks.
> > > Adding them in Cc.
> > 
> > Can we please get Ack from the LED maintainers? Thanks.
> 
> I do not think we should be adding more LED bits to the input
> subsystem/events; this functionality should be routed purely though LED
> subsystem. input-leds is a bridge for legacy input functionality
> reflecting it onto the newer LED subsystem.

If we do it purely through the LED subsystem, will it get trickier to
associate the devices?

Anyway, it is a headset. What does headset have to do with input
subsystem? Sounds like sound device to me... And we already have a
"micmute" LED which sounds quite similar to the "offhook" LED... no?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature